GLSR.pinned.onToggle - Code Metrics - Inspection of "begin forms and fields" - pryley/site-reviews - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( dc3967...a95317 )

by Paul

created 2018-05-29 09:53 UTC

GLSR.pinned.onToggle A

↳ Parent: GLSR.pinned.onClickSave

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
c	1
b	0
f	0
nc	2
nop	1
dl	0
loc	8
rs	9.4285

GLSR.pinned = function( options ) {

	this.options = x.extend( {}, this.defaults, options );

	this.el = x( this.options.selector );
	this.target = null;
	if( !this.el )return;
if (a > 0)
    b = 42;
	this.init();
};

GLSR.pinned.prototype = {


	defaults: {
		selector: '#pinned-status-select',
	},

	/** @return void */
	init: function() {
		x( 'a.cancel-pinned-status' ).on( 'click', this.onClickCancel.bind( this ));
		x( 'a.edit-pinned-status' ).on( 'click', this.onClickEdit.bind( this ));
		x( 'a.save-pinned-status' ).on( 'click', this.onClickSave.bind( this ));
		x( 'table td.sticky i' ).on( 'click', this.onClickToggle.bind( this ));
	},

	/** @return void */
	onClickCancel: function( ev ) {
		ev.preventDefault();
		this.el.slideUp( 'fast' ).siblings( 'a.edit-pinned-status' ).show().focus();
		this.el.find( 'select' ).val( x( '#hidden-pinned-status' ).val() === '0' ? 1 : 0 );
	},

	/** @return void */
	onClickEdit: function( ev ) {
		ev.preventDefault();
		if( !this.el.is( ':hidden' ))return;
if (a > 0)
    b = 42;
		this.el.slideDown( 'fast', function() {
			this.el.find( 'select' ).focus();
		}.bind( this ));
		x( this ).hide();
	},

	/** @return void */
	onClickSave: function( ev ) {
		ev.preventDefault();
		this.el.slideUp( 'fast' ).siblings( 'a.edit-pinned-status' ).show().focus();
		this.target = ev.target;
		var request = {
			action: 'toggle-pinned',
			id: x( '#post_ID' ).val(),
			pinned: x( '#pinned-status' ).val(),
		};
		this.request( request, this.save.bind( this ));
	},

	/** @return void */
	onClickToggle: function( ev ) {
		ev.preventDefault();
		this.target = ev.target;
		var request = {
			action: 'toggle-pinned',
			id: ev.target.getAttribute( 'data-id' ),
		};
		this.request( request, this.toggle.bind( this ));
	},

	/** @return void */
	request: function( request, callback ) {
		var data = {
			action: site_reviews.action,

			request: request,
		};
		x.post( site_reviews.ajaxurl, data, callback.bind( this ));

	},

	/** @return void */
	save: function( response ) {
		x( '#pinned-status' ).val( !response.pinned|0 );
		x( '#hidden-pinned-status' ).val( response.pinned|0 );
		x( '#pinned-status-text' ).text( response.pinned ? this.target.data( 'yes' ) : this.target.data( 'no' ));
		// GLSR.insertNotices( response.notices );
	},

	/** @return void */
	toggle: function( response ) {
		var action = response.pinned ? 'add' : 'remove';
		this.target[action + 'Class']( 'pinned' );
	},
};


1			GLSR.pinned = function( options ) {
			0 ignored issues – show Bug introduced 2018-05-29 10:00 UTC by Report Bug Copy Issue Report The variable `GLSR` seems to be never declared. If this is a global, consider adding a `/** global: GLSR */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
2			this.options = x.extend( {}, this.defaults, options );
			0 ignored issues – show Bug introduced 2018-05-18 14:23 UTC by Report Bug Copy Issue Report The variable `x` seems to be never declared. If this is a global, consider adding a `/** global: x */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
3			this.el = x( this.options.selector );
4			this.target = null;
5			if( !this.el )return;
			0 ignored issues – show Coding Style Best Practice introduced 2018-05-29 10:00 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
6			this.init();
7			};
8
9			GLSR.pinned.prototype = {
			0 ignored issues – show Bug introduced 2018-05-29 10:00 UTC by Report Bug Copy Issue Report The variable `GLSR` seems to be never declared. If this is a global, consider adding a `/** global: GLSR */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
10
11			defaults: {
12			selector: '#pinned-status-select',
13			},
14
15			/** @return void */
16			init: function() {
17			x( 'a.cancel-pinned-status' ).on( 'click', this.onClickCancel.bind( this ));
18			x( 'a.edit-pinned-status' ).on( 'click', this.onClickEdit.bind( this ));
19			x( 'a.save-pinned-status' ).on( 'click', this.onClickSave.bind( this ));
20			x( 'table td.sticky i' ).on( 'click', this.onClickToggle.bind( this ));
21			},
22
23			/** @return void */
24			onClickCancel: function( ev ) {
25			ev.preventDefault();
26			this.el.slideUp( 'fast' ).siblings( 'a.edit-pinned-status' ).show().focus();
27			this.el.find( 'select' ).val( x( '#hidden-pinned-status' ).val() === '0' ? 1 : 0 );
28			},
29
30			/** @return void */
31			onClickEdit: function( ev ) {
32			ev.preventDefault();
33			if( !this.el.is( ':hidden' ))return;
			0 ignored issues – show Coding Style Best Practice introduced 2018-05-29 10:00 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
34			this.el.slideDown( 'fast', function() {
35			this.el.find( 'select' ).focus();
36			}.bind( this ));
37			x( this ).hide();
38			},
39
40			/** @return void */
41			onClickSave: function( ev ) {
42			ev.preventDefault();
43			this.el.slideUp( 'fast' ).siblings( 'a.edit-pinned-status' ).show().focus();
44			this.target = ev.target;
45			var request = {
46			action: 'toggle-pinned',
47			id: x( '#post_ID' ).val(),
48			pinned: x( '#pinned-status' ).val(),
49			};
50			this.request( request, this.save.bind( this ));
51			},
52
53			/** @return void */
54			onClickToggle: function( ev ) {
55			ev.preventDefault();
56			this.target = ev.target;
57			var request = {
58			action: 'toggle-pinned',
59			id: ev.target.getAttribute( 'data-id' ),
60			};
61			this.request( request, this.toggle.bind( this ));
62			},
63
64			/** @return void */
65			request: function( request, callback ) {
66			var data = {
67			action: site_reviews.action,
			0 ignored issues – show Bug introduced 2018-05-29 10:00 UTC by Report Bug Copy Issue Report The variable `site_reviews` seems to be never declared. If this is a global, consider adding a `/** global: site_reviews */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
68			request: request,
69			};
70			x.post( site_reviews.ajaxurl, data, callback.bind( this ));
			0 ignored issues – show Bug introduced 2018-05-29 10:00 UTC by Report Bug Copy Issue Report The variable `x` seems to be never declared. If this is a global, consider adding a `/** global: x */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
71			},
72
73			/** @return void */
74			save: function( response ) {
75			x( '#pinned-status' ).val( !response.pinned\|0 );
76			x( '#hidden-pinned-status' ).val( response.pinned\|0 );
77			x( '#pinned-status-text' ).text( response.pinned ? this.target.data( 'yes' ) : this.target.data( 'no' ));
78			// GLSR.insertNotices( response.notices );
79			},
80
81			/** @return void */
82			toggle: function( response ) {
83			var action = response.pinned ? 'add' : 'remove';
84			this.target[action + 'Class']( 'pinned' );
85			},
86			};
87

pryley / site-reviews

Push — master ( dc3967...a95317 )

GLSR.pinned.onToggle A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like